-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fugue Integration #839
Fugue Integration #839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of questions and some comments around cleaning it up and clarity. Over all though it's looking in a good direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach looks really nice to integrate whylogs and fugue! Let me know how I can help.
This looks close, I think with some minor cleanup if you have your example notebook working, and the CI checks passing we can merge this? I will check tomorrow morning, and happy to help resolve issues.
Thank @jamie256 the notebook is working. I will also add some comments on the public function. Then we are good to merge. Currently I am having a hard time with poetry I am hitting this issue python-poetry/poetry#4242 and may try poetry 1.2 which fixes it. |
I updated poetry to version 1.2.1 in our CI configs as it now works after fixing the typing-extensions entry: #847 |
* update poetry version in ci configs, and update poetry.lock with poetry 1.2.1
Thanks, but please let me do that, I am making a couple of changes |
Merging poetry.lock is not fun 😢 |
Looks like you have it working! And notebooks cleaned up.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the push and all the updates here, I'll pull this into today's release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
This repository needs to integrate with Fugue so whyllogs profiling can work on Spark, Dask and Ray agnostically.
The commits in this pull request will: