Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document Write*EncodersToFile functions #52

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

Stebalien
Copy link
Collaborator

fixes #51

writefile.go Outdated
// given types in the specified file, with the specified package name.
//
// The MarshalCBOR and UnmarshalCBOR implementations will marshal/unmarshal each type's fields as a
// fixed-length array of field values.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "tuple" instead of "array"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, CBOR calls them arrays. I'll change it to "CBOR array".

Copy link

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried real hard to find a typo, but no luck :(

@Stebalien Stebalien merged commit 67a261a into whyrusleeping:master Mar 3, 2021
@Stebalien Stebalien deleted the doc/document-write-fns branch March 3, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

what's the difference between WriteTupleEncodersToFile and WriteMapEncodersToFile ?
3 participants