Add hooks to the encoder to allow encoding tags #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| // result to avoid a memory allocation. It should be a slice with a sufficient | ||
| // capacity. | ||
| func EncodeInt(tag byte, v uint64, buf []byte) []byte { | ||
| if v <= 23 { |
There was a problem hiding this comment.
these should be a switch statement
|
updated to the switch statement |
|
alright cool, LGTM |
whyrusleeping
added a commit
that referenced
this pull request
Feb 16, 2016
Add hooks to the encoder to allow encoding tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a few things here:
This is necessary to encode IPLD using tags as defined in ipfs/specs#61. The last item is useful to implement the marshaller interface and to generate the expected byte slice in unit tests.