Basic lockfile support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
reviewed
Aug 30, 2018
main.go
Outdated
| @@ -783,6 +822,43 @@ var DevCopyCommand = cli.Command{ | |||
| }, | |||
| } | |||
|
|
|||
| func genLockDeps(pkg *Package, deps map[string]gx.LockDep, done map[string]bool, ignoreConflict bool) error { | |||
There was a problem hiding this comment.
Could we use the DependencyQueue here? (I'm not sure, since it belongs to the gx repo).
Ideally I would like to have a function that just returns all the (unique) dependencies of a package. From what I'm seeing in the gx/gx-go code bases we're doing a lot of "get me all your direct and transitive dependencies" (converting Dependency to Package) types of operation.
schomatis
reviewed
Aug 30, 2018
| return err | ||
| } | ||
|
|
||
| ref := fmt.Sprintf("/ipfs/%s/%s", dep.Hash, dep.Name) |
There was a problem hiding this comment.
This seems to be (along with the gx.LockDep{ line) the actual core of the function where we are transforming a Dependency to a LockDep/Ref, could we add a comment to highlight this? (And even better, make it into a function.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basic support for a lock-file concept discussed between @Stebalien and @whyrusleeping this week.
See also: whyrusleeping/gx#206