-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render ipypopout content in jupyter notebook and lab #805
Conversation
fa16d9c
to
fc612a9
Compare
fc612a9
to
a4fae04
Compare
Should be used in combination with: widgetti/solara#805
a4fae04
to
7145c03
Compare
7145c03
to
f931c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments, otherwise looks good!
solara/server/jupyter/solara.py
Outdated
abspath = os.path.abspath(os.path.join(root, path)) | ||
for root in self.roots[1:]: | ||
abspath = os.path.abspath(os.path.join(root, path)) | ||
# return early if someone tries to access a file outside of the directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I follow what this comment is trying to say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was a leftover comment, I'll remove it. Thanks
Instead of having to rely on voila to display widgets in a popout window, solara itself now can render it. This allows project to drop the dependency on voila.
f931c6f
to
200fc2f
Compare
Should be used in combination with: widgetti/solara#805
Should be used in combination with: widgetti/solara#805
Should be used in combination with: widgetti/solara#805
Should be used in combination with: widgetti/solara#805
Should be used in combination with: widgetti/solara#805
This for instance broke ipyaggrid >=0.5.2 due to changes in #805
This for instance broke ipyaggrid >=0.5.2 due to changes in #805
This for instance broke ipyaggrid >=0.5.2 due to changes in #805
Instead of having to rely on voila to display widgets in a popout window, solara itself now can render it. This allows project to drop the dependency on voila.