ListManager: Catch invalid BES regex patterns and log them

Fixes #28
wikimedia · Oct 13, 2017 · a55e212 · a55e212
1 parent 22861dd
commit a55e212
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/src/CVNBot/ListManager.cs b/src/CVNBot/ListManager.cs
@@ -772,6 +772,23 @@ public listMatch isWatchedArticle(string title, string project)
             return lm;
         }
 
+        public bool matchesPattern(string input, string pattern) {
+            listMatch lm = new listMatch();
+            try
+            {
+                if (Regex.IsMatch(input, pattern, RegexOptions.IgnoreCase))
+                {
+                    return true;
+                }
+            } catch (Exception ex)
+            {
+                logger.Warn("Found invalid pattern: " + pattern, ex);
+                Program.BroadcastDD("ERROR", "LMGNR_REGEX", ex.Message, input);
+            }
+
+            return false;
+        }
+
         public listMatch matchesList(string title, int list)
         {
             listMatch lm = new listMatch();
@@ -784,7 +801,7 @@ public listMatch matchesList(string title, int list)
                 IDataReader idr = cmd.ExecuteReader();
                 while (idr.Read())
                 {
-                    if (Regex.IsMatch(title, idr.GetString(0), RegexOptions.IgnoreCase))
+                    if (matchesPattern(title, idr.GetString(0)))
                     {
                         lm.Success = true;
                         lm.matchedItem = idr.GetString(0);