Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate running from a shared binary #34

Closed
Krinkle opened this issue Oct 27, 2017 · 2 comments
Closed

Evaluate running from a shared binary #34

Krinkle opened this issue Oct 27, 2017 · 2 comments

Comments

@Krinkle
Copy link
Member

Krinkle commented Oct 27, 2017

I'm not entirely sure, but it should be possible to have the multiple instances on the same server run from the same executable.

Right now the executable assumes a specific working directory where everything is self-contained. And I wouldn't be surprised if some parts of the code actually lookup paths relative to where the binary is stored as opposed to relative to the current working directory.

Status quo:

  • Moving the executable currently makes the process fail.
  • Not running it from the bot's own working directory also makes the process fail.

Assuming multiple instances of the same executable isn't infeasible in general, we can make it work for multiple instances either by standardising on utilizing the current working directory for everything, or (better yet) by passing the bot directory via command-line argument.

We'd need to make sure that argument gets preserved on respawn/restart.

@Krinkle Krinkle added this to the 1.22.0 milestone Oct 27, 2017
@Krinkle Krinkle modified the milestones: 1.22, 1.23 Dec 27, 2018
@Krinkle Krinkle removed this from the 3.x milestone Jun 9, 2020
@Krinkle
Copy link
Member Author

Krinkle commented Jan 17, 2023

@Krinkle Krinkle closed this as completed Jan 17, 2023
rxy pushed a commit to rxy/CVNBot that referenced this issue Apr 8, 2023
Should fix the following kind of log error:

> WARN  [RCReader] CVNBot.RCReader [CVNBot1] Unmatched create2 event in en.wikipedia:
> #00314[[#00307Special:Log/newusers#00314]]wikimedia#34 create2#00310 #00302#003 wikimedia#35*wikimedia#3
> #00303Ujju.19788#003 wikimedia#35*wikimedia#3  #00310created new account User:Upendhare#003

Fixes wikimedia#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant