Dispose disposable objects, hopefully fixes leak #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I profiled app using https://github.com/DavidKarlas/Krofiler/ on Mac which is profiling managed objects, and there was no leak, but memory usage grew... Hence it must be native leak, I notice use of Sqlite, so I looked for usage of
using
and saw few missing, possibly fixes the leak. I can't confirm because its not clear how long memory grows because sqlite caching and leak.I suggest comparing with ignore whitespace. https://github.com/countervandalism/CVNBot/pull/63/files?w=1
P.S: This is pretty old mono hence don't want to use new
using
syntax to avoid problems.