Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose disposable objects, hopefully fixes leak #63

Closed
wants to merge 1 commit into from

Conversation

DavidKarlas
Copy link
Contributor

@DavidKarlas DavidKarlas commented Jun 8, 2020

I profiled app using https://github.com/DavidKarlas/Krofiler/ on Mac which is profiling managed objects, and there was no leak, but memory usage grew... Hence it must be native leak, I notice use of Sqlite, so I looked for usage of using and saw few missing, possibly fixes the leak. I can't confirm because its not clear how long memory grows because sqlite caching and leak.

I suggest comparing with ignore whitespace. https://github.com/countervandalism/CVNBot/pull/63/files?w=1

P.S: This is pretty old mono hence don't want to use new using syntax to avoid problems.

@DavidKarlas
Copy link
Contributor Author

DavidKarlas commented Jun 8, 2020

Probably fixes #13

@DavidKarlas
Copy link
Contributor Author

I ran for some time, and it kept going up, also look at code for disposing, and looks like it doesn't dispose native part... Hence closing...

@DavidKarlas DavidKarlas closed this Jun 8, 2020
@reedy
Copy link
Member

reedy commented Jun 8, 2020

This is probably still beneficial as good practice

@DavidKarlas DavidKarlas reopened this Jun 8, 2020
@DavidKarlas
Copy link
Contributor Author

Ok, reopened, and removed comment about fixing.

@Krinkle Krinkle closed this in 26ae521 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants