Merge "Prevent getAllStatements from returning mutable entity stateme…

…nts"

client/includes/DataAccess/Scribunto/mw.wikibase.entity.lua

@@ -248,6 +248,21 @@ function methodtable.getSitelink( entity, globalSiteId )
 	return sitelink.title
 end
 
+-- @param {table} original
+local function deepCopyTable(original)
+    local copy = {}
+    for k, v in pairs(original) do
+        if type(v) == "table" then
+            -- Recursively copy tables
+            copy[k] = deepCopyTable(v)
+        else
+            -- Directly copy non-table values
+            copy[k] = v
+        end
+    end
+    return copy
+end
+
 -- @param {table} entity
 -- @param {string} propertyLabelOrId
 -- @param {string} funcName for error logging
@@ -266,7 +281,8 @@ local function getEntityStatements( entity, propertyLabelOrId, funcName )
 	end
 
 	if propertyId and entity.claims[propertyId] then
-		return entity.claims[propertyId]
+		-- Create a deep copy of the statements table to prevent entity mutability.
+		return deepCopyTable(entity.claims[propertyId])
 	end
 
 	return {}

client/tests/phpunit/integration/includes/DataAccess/Scribunto/WikibaseLibraryTests.lua

@@ -44,6 +44,15 @@ local function testGetAllStatementsFormat()
 	return directBestAccess ~= directAccess and directAccess == entityAccess
 end
 
+local function testGetAllStatementsTableIsCloned()
+	local statements = mw.wikibase.getAllStatements( 'Q32487', 'P342' )
+	table.remove(statements)
+
+	-- We should get a freshly cloned table here, so the changes above won't persist
+	local newStatements = mw.wikibase.getAllStatements( 'Q32487', 'P342' )
+	return #statements == #newStatements -1
+end
+
 local function testGetEntityObjectIsCloned()
 	mw.wikibase.getEntityObject( 'Q199024' ).id = 'a'
 
@@ -170,6 +179,9 @@ local tests = {
 	{ name = 'mw.wikibase.getAllStatements (format)', func = testGetAllStatementsFormat,
 	  expect = { true }
 	},
+	{ name = 'mw.wikibase.getAllStatements (is cloned)', func = testGetAllStatementsTableIsCloned,
+      expect = { true }
+  	},
 	{ name = 'mw.wikibase.getEntityObject (is cloned)', func = testGetEntityObjectIsCloned, type='ToString',
 	  expect = { 'Q199024' }
 	},