Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL support #37

Merged
merged 6 commits into from
Aug 6, 2020
Merged

RTL support #37

merged 6 commits into from
Aug 6, 2020

Conversation

stephanebisson
Copy link
Collaborator

https://phabricator.wikimedia.org/T240005

Specify lang and dir attributes at the top level of the preview markup and adjust some css rules to flip some items.

hueitan
hueitan requested changes Aug 4, 2020
View reviewed changes
Copy link
Member

@hueitan hueitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing, we need to flip the left/right action key in the full screen gallery view

hueitan
hueitan approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@hueitan hueitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good! Nice work.

@hueitan hueitan merged commit faa185d into master Aug 6, 2020
@hueitan hueitan deleted the T240005-rtl branch August 6, 2020 19:39
@stephanebisson stephanebisson restored the T240005-rtl branch May 13, 2021 17:27
@stephanebisson stephanebisson deleted the T240005-rtl branch May 13, 2021 17:31
@stephanebisson stephanebisson restored the T240005-rtl branch July 28, 2022 12:56
@stephanebisson stephanebisson deleted the T240005-rtl branch July 28, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hueitan hueitan hueitan approved these changes

@medied medied Awaiting requested review from medied

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanebisson @hueitan