-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8.0 to CI #380
Add PHP 8.0 to CI #380
Conversation
Bumped doctrine-migrations-bundle for doctrine/migrations#1104 |
I think the following PHP8 notice should be fixed:
Then I see there are more hidden deprecation warnings, but those are also for PHP 7.3, hence not blocking this. |
That looks to be coming from Intuition which in turn is getting it from MediaWiki, where it's already been fixed. I think Intuition needs to update it's mw-classes directory… I'll look into that. |
Oh, I didn't realize it was from an external dependency! It might not be easy to fix then, considering that AFAICS those classes were last touched several years ago. Given that this change only adds testing for PHP 8 (and doesn't change the requirement in composer.json, which already includes PHP 8 BTW), and that this is just a notice, I'm going to merge it as-is. |
No description provided.