Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.0 to CI #380

Merged
merged 9 commits into from
Sep 29, 2021
Merged

Add PHP 8.0 to CI #380

merged 9 commits into from
Sep 29, 2021

Conversation

samwilson
Copy link
Member

No description provided.

@Daimona
Copy link
Contributor

Daimona commented Sep 22, 2021

Bumped doctrine-migrations-bundle for doctrine/migrations#1104

@Daimona
Copy link
Contributor

Daimona commented Sep 23, 2021

I think the following PHP8 notice should be fixed:

1x: Required parameter $code follows optional parameter $prefix
1x in BookCreatorIntegrationTest::testCreateBookEpub3 from App\Tests\BookCreator

Then I see there are more hidden deprecation warnings, but those are also for PHP 7.3, hence not blocking this.

@samwilson samwilson added WIP Work in progress and removed Ready for review labels Sep 29, 2021
@samwilson
Copy link
Member Author

I think the following PHP8 notice should be fixed:

1x: Required parameter $code follows optional parameter $prefix
1x in BookCreatorIntegrationTest::testCreateBookEpub3 from App\Tests\BookCreator

Then I see there are more hidden deprecation warnings, but those are also for PHP 7.3, hence not blocking this.

That looks to be coming from Intuition which in turn is getting it from MediaWiki, where it's already been fixed. I think Intuition needs to update it's mw-classes directory… I'll look into that.

@Daimona
Copy link
Contributor

Daimona commented Sep 29, 2021

I think the following PHP8 notice should be fixed:

1x: Required parameter $code follows optional parameter $prefix
1x in BookCreatorIntegrationTest::testCreateBookEpub3 from App\Tests\BookCreator

Then I see there are more hidden deprecation warnings, but those are also for PHP 7.3, hence not blocking this.

That looks to be coming from Intuition which in turn is getting it from MediaWiki, where it's already been fixed. I think Intuition needs to update it's mw-classes directory… I'll look into that.

Oh, I didn't realize it was from an external dependency! It might not be easy to fix then, considering that AFAICS those classes were last touched several years ago. Given that this change only adds testing for PHP 8 (and doesn't change the requirement in composer.json, which already includes PHP 8 BTW), and that this is just a notice, I'm going to merge it as-is.

@Daimona Daimona closed this Sep 29, 2021
@Daimona Daimona reopened this Sep 29, 2021
@Daimona Daimona merged commit 9431a91 into main Sep 29, 2021
@Daimona Daimona deleted the php8 branch September 29, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Development

Successfully merging this pull request may close these issues.

2 participants