-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contributor set-up instructions #471
Conversation
Change the main install instructions to target developers, because they're more likely to be the ones following this.
As previously promised, I've proposed changes to this branch in #475. |
|
||
app:check [-l|--lang LANG] [--nocache] [-t|--title TITLE] [-c|--count COUNT] [-s|--namespaces NAMESPACES] | ||
```console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waldyrious I didn't notice this before, sorry. This section of CLI usage is auto-generated (by this thing), so shouldn't be changed by hand. I thought we had a CI check in place to guard against this; I'm adding such a thing in #476.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, no worries. Would you like me to revert the changes to the "CLI Usage" section, and keep the changes to the other sections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime, I submitted samwilson/console-readme-generator#7 to change this formatting in the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! And no, it's fine to leave them as-is here, I'll merge that change and then we can update the package here.
Okay, I think this is good to go now. |
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
Change the main install instructions to target developers, because they're more likely to be the ones following this. #wmhack