Handle unqualified image src attrs #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the domain name to image src values that don't have one, to support WikiHiero. Also move the protocol-relative handling out of the PageParser so that it can go along with the new domain name adding in one place. Bug: T354242
Tpt
approved these changes
Aug 14, 2024
samwilson
added a commit
that referenced
this pull request
Aug 15, 2024
The change I made in #513 fixed the URLs after they were used to fetch the images! This moves that same logic to the location in which it'll actually work. Sorry for the noise! Bug: T354242
samwilson
added a commit
that referenced
this pull request
Aug 15, 2024
The change I made in #513 fixed the URLs after they were used to fetch the images! This moves that same logic to the location in which it'll actually work. Sorry for the noise! Bug: T354242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the domain name to image src values that don't have one, to support WikiHiero. Also move the protocol-relative handling out of the PageParser so that it can go along with the new domain name adding in one place.
Bug: T354242