Rollback changes in case of unsucessful apply stage #708
Conversation
spyrkob
force-pushed
the
atomic_apply
branch
13 times, most recently
from
6fc6698
to
30ef534
Compare
|
@TomasHofman if you have a moment could you review this PR please? |
|
Sure, will check. |
| // fallback on copy if Filesystem doesn't support hardlinks | ||
| try { | ||
| Files.createLink(backupRoot.resolve(relative), file); | ||
| } catch (UnsupportedEncodingException e) { |
There was a problem hiding this comment.
Is that the exception that's gonna be thrown when unable to create a hardlink? I would expect UnsupportedOperationException.
There was a problem hiding this comment.
We may try to check explicitly if the paths are on the same filesystem and revert to copy if they are not, to avoid the exception. It would not simplify the code, just avoided the exception in one predictable case. No big deal though.
There was a problem hiding this comment.
good catch, thanks. That should be UnsupportedOperationException.
We may try to check explicitly if the paths are on the same filesystem.
That would assume the installation of WildFly itself is split between different filesystems, Is that something we support/anticipate?
spyrkob
force-pushed
the
atomic_apply
branch
2 times, most recently
from
231976f
to
66e77d6
Compare
Before applying changes to a server, backup the state of the server in a
<SERVER_HOME>.update.oldfolder. The backup is done using hardlinks if the file system allows it to save disk space.If the update fails due to IOException, we try and restore the server state. If the update is interrupted, either by the user or a program crash, the original state will be available for the user to perform manual restore.