Prevent making changes when conflicts in an update are rejected #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyrkob
force-pushed
the
fix_changes_when_update_rejected
branch
2 times, most recently
from
6fed26a
to
9210c74
Compare
spyrkob
force-pushed
the
fix_changes_when_update_rejected
branch
from
9210c74
to
a756784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conflicts are resolved too early resulting in the changes being written even if the update has been rejected.
To reproduce:
update applyand reject update after the conflicts are displayedThe module.xml will be updated (and module.xml.glold will be created)