Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFLY-15849] Add OpenTelemetry quickstart #544

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[WFLY-15849] Add OpenTelemetry quickstart #544

merged 1 commit into from
Jan 22, 2024

Conversation

jasondlee
Copy link
Contributor

https://issues.redhat.com/browse/WFLY-15849

Add a QS for OpenTelemetry

@jasondlee
Copy link
Contributor Author

@emmartins Would love some feedback on scope, structure, etc.

@jasondlee jasondlee force-pushed the WFLY-15849 branch 3 times, most recently from ae03bf3 to e87696d Compare July 12, 2023 21:52
@jasondlee jasondlee force-pushed the WFLY-15849 branch 2 times, most recently from bd4ae68 to 4b14415 Compare October 2, 2023 17:59
@jasondlee
Copy link
Contributor Author

@emmartins I think this one should be ready now

@jasondlee jasondlee force-pushed the WFLY-15849 branch 2 times, most recently from b58384c to f512cbf Compare November 15, 2023 16:19
@jasondlee jasondlee changed the title [WFLY-15849] OpenTelemetry QS [WFLY-15849] Add OpenTelemetry quickstart Nov 29, 2023
emmartins
emmartins requested changes Dec 14, 2023
View reviewed changes
.github/workflows/quickstart_opentelemetry_ci.yml Outdated Show resolved Hide resolved
opentelemetry-tracing/configure-opentelemetry.cli Outdated Show resolved Hide resolved
opentelemetry-tracing/README.adoc
endif::[]
// Bootable JAR
include::../shared-doc/build-and-run-the-quickstart-with-bootable-jar.adoc[leveloffset=+1]
// OpenShift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also provide instructions on how to setup the docker service for openshift.

opentelemetry-tracing/pom.xml Show resolved Hide resolved
opentelemetry-tracing/pom.xml Show resolved Hide resolved
opentelemetry-tracing/pom.xml Outdated Show resolved Hide resolved
@jasondlee
Copy link
Contributor Author

@emmartins Changes pushed.

@jasondlee jasondlee requested a review from emmartins December 14, 2023 14:51
@jasondlee jasondlee force-pushed the WFLY-15849 branch 2 times, most recently from 8880ab3 to 6b1c297 Compare December 15, 2023 16:44
@emmartins
Copy link
Contributor

WFLY 31.0.0.Beta1 has been released, please rebase this PR with upstream/main branch, and update:

  • All pom.xml to 31.0.0.Final-SNAPSHOT
  • All pom.xml to 6
  • Property named version.server to 31.0.0.Beta1
  • Property named version.plugin.wildfly to 4.2.1.Final

emmartins
emmartins requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes I believe.

opentelemetry-tracing/README.adoc Outdated Show resolved Hide resolved
opentelemetry-tracing/README.adoc Outdated Show resolved Hide resolved
@emmartins
Copy link
Contributor

@kstekovi no matter requesting changes, those are very minor, I think this feature PR is ready for upstream merge pre-check

@emmartins
Copy link
Contributor

/retest

emmartins
emmartins approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kstekovi
kstekovi reviewed Jan 9, 2024
View reviewed changes
opentelemetry-tracing/README.adoc Show resolved Hide resolved
opentelemetry-tracing/README.adoc Show resolved Hide resolved
opentelemetry-tracing/README.adoc Show resolved Hide resolved
opentelemetry-tracing/README.adoc Show resolved Hide resolved
emmartins
emmartins approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, if needed I can do the minor 2 changes post merge

opentelemetry-tracing/README.adoc Outdated Show resolved Hide resolved
opentelemetry-tracing/README.adoc Outdated Show resolved Hide resolved
@emmartins
Copy link
Contributor

@jasondlee thanks for the changes, LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 19, 2024

@jasondlee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/wildfly-quickstart-e2e 89408bd link true /test wildfly-quickstart-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kstekovi
Copy link
Contributor

kstekovi commented Jan 22, 2024 •
edited
Loading

everything LGTM. I don't have any topics for discussion.

The OpenShift part is not ready yet.

@emmartins emmartins merged commit 8e20467 into wildfly:main Jan 22, 2024
19 of 20 checks passed
@emmartins
Copy link
Contributor

merging, thank you both, please don't forget we now should work on a new PR properly handling OpenShift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstekovi kstekovi kstekovi left review comments

@emmartins emmartins emmartins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasondlee @emmartins @kstekovi