Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18466] ejb-security-context-propagation Quickstart Common Enhan… #751

Conversation

PrarthonaPaul
Copy link

@PrarthonaPaul PrarthonaPaul commented Oct 17, 2023

…cements CY2023Q3
Issue: https://issues.redhat.com/browse/WFLY-18466
Note: This QS is open shift incompatible, requires adding users using add-user.sh file and did not have a web endpoint, instead we used mvn exec:exec to check the output.
A new endpoint has been added to test successful deployment. It does not test any ejb functionalities. Just outputs helloworld if connection is successful.

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

Hi @PrarthonaPaul. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PrarthonaPaul PrarthonaPaul force-pushed the ejb-security-context-propagation-enhancements branch 3 times, most recently from a713023 to bf4701d Compare October 19, 2023 19:39
@PrarthonaPaul PrarthonaPaul marked this pull request as ready for review October 19, 2023 19:43
Copy link
Contributor

@emmartins emmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the pointed needed changes there is also the missing update for the README.adoc...
But this QS is again an example of where we need deeper changes, in this particular case the troubles are mostly around the usage of exec:exec, which should be replaced by functional integration testing. There are a few things I need to add also to shared resources, so this time I will send you a PR with all the fixes.

@PrarthonaPaul PrarthonaPaul force-pushed the ejb-security-context-propagation-enhancements branch 3 times, most recently from 1966088 to ceceef6 Compare October 26, 2023 13:11
@PrarthonaPaul PrarthonaPaul force-pushed the ejb-security-context-propagation-enhancements branch from ceceef6 to b857d9f Compare October 26, 2023 19:13
@emmartins emmartins merged commit af84e8e into wildfly:main Oct 26, 2023
203 of 211 checks passed
@emmartins
Copy link
Contributor

thank you @PrarthonaPaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants