-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-18466] ejb-security-context-propagation Quickstart Common Enhan… #751
[WFLY-18466] ejb-security-context-propagation Quickstart Common Enhan… #751
Conversation
Hi @PrarthonaPaul. Thanks for your PR. I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a713023
to
bf4701d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the pointed needed changes there is also the missing update for the README.adoc...
But this QS is again an example of where we need deeper changes, in this particular case the troubles are mostly around the usage of exec:exec, which should be replaced by functional integration testing. There are a few things I need to add also to shared resources, so this time I will send you a PR with all the fixes.
.github/workflows/quickstart_ejb_security_context_propagation_ci.yml
Outdated
Show resolved
Hide resolved
.github/workflows/quickstart_ejb_security_context_propagation_ci.yml
Outdated
Show resolved
Hide resolved
...tion/src/main/java/org/jboss/as/quickstarts/ejb_security_context_propagation/EJBServlet.java
Outdated
Show resolved
Hide resolved
...tion/src/main/java/org/jboss/as/quickstarts/ejb_security_context_propagation/EJBServlet.java
Outdated
Show resolved
Hide resolved
1966088
to
ceceef6
Compare
ceceef6
to
b857d9f
Compare
thank you @PrarthonaPaul |
…cements CY2023Q3
Issue: https://issues.redhat.com/browse/WFLY-18466
Note: This QS is open shift incompatible, requires adding users using
add-user.sh
file and did not have a web endpoint, instead we used mvn exec:exec to check the output.A new endpoint has been added to test successful deployment. It does not test any ejb functionalities. Just outputs helloworld if connection is successful.