Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security domain to domain enhancements #887

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Security domain to domain enhancements #887

merged 2 commits into from
Mar 26, 2024

Conversation

emmartins
Copy link
Contributor

@emmartins emmartins commented Mar 26, 2024 •
edited
Loading

Issue: https://issues.redhat.com/browse/WFLY-18503

Superseds #749 with an additional commit, with the following changes:

  • Moves README.adoc to README-source.adoc
  • Removes include for outdated sections wrt IDEs and debug
  • Syncs pom version properties
  • Fixes server provisioning config
  • When server provisioning put the war at root context (through config of ear)
  • Moves test to a new test module

@emmartins emmartins mentioned this pull request Mar 26, 2024
Closed
@emmartins
Copy link
Contributor Author

tests are good so @PrarthonaPaul please give the 2nd commit a look, the other one is your original one from #749

PrarthonaPaul
PrarthonaPaul approved these changes Mar 26, 2024
View reviewed changes
Copy link

@PrarthonaPaul PrarthonaPaul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the updates @emmartins

@emmartins emmartins merged commit e6c3a42 into wildfly:main Mar 26, 2024
20 checks passed
@emmartins emmartins deleted the security-domain-to-domain-enhancements branch March 26, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrarthonaPaul PrarthonaPaul PrarthonaPaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmartins @PrarthonaPaul