Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-19345] microprofile-openapi Quickstarts should have a root webpage similar to helloworld #912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sudeshnas93
Copy link
Contributor

Copy link

openshift-ci bot commented May 16, 2024

Hi @sudeshnas93. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@emmartins
Copy link
Contributor

hi @sudeshnas93 , this QS already has a root page, in this case served by src/main/java/org/wildfly/quickstart/microprofile/openapi/RootResource.java

@sudeshnas93
Copy link
Contributor Author

hi @sudeshnas93 , this QS already has a root page, in this case served by src/main/java/org/wildfly/quickstart/microprofile/openapi/RootResource.java

Yes, but do we still need a index.html as we did for other microprofile quickstarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants