Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to use a different feature-packs URL for WildFly SNAPSHOT #916

Merged
merged 2 commits into from
May 24, 2024

Conversation

jfdenise
Copy link
Contributor

Recent refactoring of https://github.com/wildfly/wildfly-galleon-feature-packs removed this requirement.
@kabir FYI.

@jfdenise jfdenise requested a review from emmartins as a code owner May 21, 2024 08:08
@jfdenise jfdenise requested review from kabir and removed request for emmartins May 21, 2024 08:08
…ver, required to set the postgresql env variables
@jfdenise
Copy link
Contributor Author

I added this unrelated change: 3d174e8
Without this fix, ejb-tx-remote-call quickstart can't succeed.

Copy link
Contributor

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfdenise Do you have a bit more info about the -Pprovisioned-server needed for the ejb-txn-remote-call one?
I remember wondering about that some time back

@jfdenise
Copy link
Contributor Author

@kabir , we configure the env there: https://github.com/wildfly/quickstart/blob/main/ejb-txn-remote-call/client/pom.xml#L219 This is done in the profile provisioned-server

@emmartins emmartins merged commit 670c4c8 into wildfly:main May 24, 2024
526 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants