[WFLY-19618] Helloworld REST Quickstart

[theashiot]

Issue: https://issues.redhat.com/browse/WFLY-19618

[emmartins]

Let's change a bit the Quickstart, to become the helloworld with only one change, we replace the servlet class with the classes for the REST app and the REST endpoint, in short considering this PR we do the following changes:

• remove the cdi bean HelloService
• we sync the test class with helloworld quickstart (you may improve both, but we should have both in sync)
• we change the HelloWorld REST endpoint to interface with the user exactly as helloworld:

/*
 * Copyright The WildFly Authors
 * SPDX-License-Identifier: Apache-2.0
 */
package org.jboss.as.quickstarts.rshelloworld;

import jakarta.inject.Inject;
import jakarta.ws.rs.GET;
import jakarta.ws.rs.Path;
import jakarta.ws.rs.Produces;

/**
 * A simple REST service which is able to say "Hello World!"" at /HelloWorld
 *
 */
@Path("/")
public class HelloWorld {
    @GET
    @Path("/HelloWorld")
	@Produces(MediaType.TEXT_PLAIN)
    public String getHelloWorldJSON() {
        return "<h1>Hello World!</h1>";
    }
} 

• update the README-source according to changes above

[theashiot]

Thanks, @emmartins for the review! I've made the required changes.

Do you want me to create a separate WFLY issue to update the HelloWorld quickstart test? I think it'd be good to test whether the response contains "Hello World!", WDYT?

best,
ashwin

[jamezp]

There should probably be a CI workflow for this as well.

[jamezp]

There should be no need for this repository.

[emmartins]

+1

[emmartins]

This change should extend to the guide itself, by default users should only add the jboss.org Repo, but we should give optional instructions wrt adding also GA repo, since some apps may require it (e.g. microprofile-jwt quickstart).

[theashiot]

removed

[jamezp]

It seems a little strange to me to have two different tests here. Both should likely be asserting on the status code.

Also, is there a reason not to use the REST Client given this is a REST quickstart?

[emmartins]

+1

[theashiot]

Created a new class that uses a REST client: https://github.com/wildfly/quickstart/pull/953/files#diff-76464e0c59b997d4e308fd7c0f653e92733f182358fe8ef6f620f132347e10cd

[jamezp]

The method name should be changed as this isn't a JSON response.

Also should we add a @PathParam("name") and great with the name instead of world? e.g.

@GET
@Path("/hello/{name}")
@Produces(MediaType.TEXT_PLAIN)
public String hello(@PathParam("name") final String name) {
    return String.format("Hello %s!", name);
}

Not needed, but just shows a simple path parameter too.

[emmartins]

I agree with renaming the method, but not with introducing the parameter since this would complicate the interaction (should be the simplest as possible) and documentation

[theashiot]

updated the method name.

[theashiot]

Thanks, @jamezp for the review! I've started implementing the changes. I'll let you know when the PR is ready for review again.

cheers,
ashwin

[theashiot]

Thanks a lot @jamezp and @emmartins for the review! I've made the changes. Can you please have another look?

best,
ashwin