Added missing groupId for maven-war-plugin #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AIUI any <xs:element minOccurs="0" name="groupId" type="xs:string" default="org.apache.maven.plugins">I never use it, that said I don't have a strong opinion either way. |
|
I see. You can close this pull request if you consider it not necessary. But all other maven plugins define a groupId in the archetypes, so I think it is more consistent. |
|
We can see what others think. I don't mind much either either way TBH. |
jamezp
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"maven-war-plugin" had no groupId. It worked anyway, but it is cleaner to declare it.