[WFMP-186] Optimize the application image generated by the image goal #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the image goal, skip the deployment when packaging WildFly In the generated Dockerfile, use 2 different COPY commands: * COPY the server bits. This Docker layer can be cached (as long as the server provisioning does not change) * COPY the deployment in the standalone/deployment directory. This Docker layer is small (the size of the deployment) and will be changed every time With that optimization, repeatedly pushing the application image will mean to push the deployment Docker layer only. This optimization saves time, bandwith and storage on the container registry. JIRA: https://issues.redhat.com/browse/WFMP-186 Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jamezp
approved these changes
Feb 22, 2023
|
Nothing to do with this PR, but just noticed it. Should we drop 26 support and testing or should we keep it? |
I'd recommend to keep it. WildFly 26 is the last release that supports Jakarta EE 9. We should leave more time to users to update their app to Jakarta EE 10 and WildFly 27+. |
|
If @jfdenise is okay with this, we can merge it. |
jfdenise
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the image goal, skip the deployment when packaging WildFly
In the generated Dockerfile, use 2 different COPY commands:
With that optimization, repeatedly pushing the application image will mean to push the deployment Docker layer only.
This optimization saves time, bandwith and storage on the container registry.
JIRA: https://issues.redhat.com/browse/WFMP-186