[WFMP-208]: dev mode deployment runtime name is not configurable. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
requested changes
May 26, 2023
| * | ||
| * When the deployment is copied to the server, it is renamed with this name. | ||
| */ | ||
| @Parameter(property = PropertyNames.DEPLOYMENT_NAME) |
There was a problem hiding this comment.
I'm on my phone so it's hard to see, but if the run goal has this field, we should remove it from there. Or just move this field into the DevMojo.
There was a problem hiding this comment.
yes it has but not the StartMojo also the RunMojo has runtimeName which is deperecated in the PackageServerMojo
There was a problem hiding this comment.
@jamezp I don't see the point of adding this field to the 'parent' class AbstractServerStartMojo and it doesn't make sense in the context of StartMojo. So I don't think we should 'move' it out :)
* Adding a new 'name' parameter with the same property as for the package mojo. Jira: https://issues.redhat.com/browse/WFMP-208 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
jamezp
approved these changes
May 28, 2023
jamezp
requested changes
May 28, 2023
|
Replaces by #350 to get this change into the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/WFMP-208