Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFMP-232] Add support for bootable JAR #441

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jfdenise
Copy link
Contributor

No description provided.

Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I'm going to file a JIRA and probably file a follow up PR with some refactoring to get ready for the split so we can test it before we do the split.

@@ -16,7 +18,7 @@
* @author <a href="mailto:jperkins@redhat.com">James R. Perkins</a>
*/
@SuppressWarnings({ "WeakerAccess", "Duplicates" })
class Environment {
public class Environment {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this needs to be public?

@jamezp jamezp changed the title Add support for bootable JAR [WFMP-232] Add support for bootable JAR Dec 13, 2023
@jamezp jamezp merged commit e853bab into wildfly:main Dec 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants