Fix some minor typos, bugs and the GitHub CI workflows #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Davis <andrew.davis@ukaea.uk>
nmnobre
force-pushed
the
qol_fixes
branch
7 times, most recently
from
a7030c5 to
78d0b6e
Compare
Previously, the new no. of faces printed after remove duplicates didn't take into account the removal of repeated faces w/ opposite orientation and of degenerate faces, i.e. those w/ repeated vertices or too small an area. In addition, the edge collapsing and swapping log msgs used to speak of faces, which while technically correct, could be confusing since we're talking 2d faces, i.e. edges.
nmnobre
force-pushed
the
qol_fixes
branch
4 times, most recently
from
2254de1 to
be9873a
Compare
nmnobre
changed the title
See the Container data races section [container.requirements.dataraces] of the C++ standard. You can find draft documents hosted at https://www.open-std.org/jtc1/sc22/wg21/docs/standards#14882.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Yixin-Hu, @danielepanozzo,
These are just some quality-of-life improvements/updates to keep the project alive. :-)
It'd be nice if we could have a chat (even if just via email) about some new features I'm implementing.
Kind regards,
-Nuno Nobre