Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/xl #291

Merged
merged 31 commits into from
Oct 29, 2024
Merged

Feature/xl #291

merged 31 commits into from
Oct 29, 2024

Conversation

mostafakalhor
Copy link
Contributor

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Technical details

Additional context

@mostafakalhor
annotate_spectral_library_xl Finished annotating
42684cc
@mostafakalhor
annotaton part is done , working on koina part
0675a10
@mostafakalhor
ce calibration is working
14af44f
@mostafakalhor
feature generation is done - working on percoltor part
434059b
@mostafakalhor
rescoring is working on csm level - all features and numThreads must …
32978b1 
…be checked
@mostafakalhor
plots are working
ae7f423
@mostafakalhor
xl_fdr of uxls fixed
4d8e00b
@mostafakalhor
seems scout is working
5f64471
@mostafakalhor
paper results is based on this version
1c6ec29
@mostafakalhor
Merge branch 'development' into feature/xl
7a3a676
@mostafakalhor
merging last version of development to xl/feature and fix conflicts
cad7c14
@mostafakalhor
fixing conflicts
97c00f0
@mostafakalhor
adding func to provide xifdr input
bc10316
@mostafakalhor
input xifdr function for xisearch results is working
cffb185
@mostafakalhor
generating xifdr input is working for both xisearch and scout
8c84612
@mostafakalhor
fixed unit tests
0f4d585
@mostafakalhor
linting
94d07e2
@mostafakalhor
updated deps to new io und fundamentals versions
276fc8a
@mostafakalhor
cleanup runner for xl code
be15b9a
@mostafakalhor
added runner unit test and required data for xl
80acbc1
@mostafakalhor
fixed docstrings
389b9cd
@github-actions github-actions bot added the enhancement New feature or request label Oct 27, 2024
@mostafakalhor mostafakalhor requested a review from WassimG October 29, 2024 07:58
@WassimG
Copy link
Contributor

WassimG commented Oct 29, 2024

In koina.py, why are you copying column data to shuffle? You can rename columns instead of wasting time and memory by copying and inserting data from one column to another.

@mostafakalhor mostafakalhor merged commit 58ee21b into development Oct 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WassimG WassimG WassimG approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mostafakalhor @WassimG