Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: avoid breaking Libc.getuid call #292

Merged
merged 1 commit into from
Nov 5, 2024
Merged

windows: avoid breaking Libc.getuid call #292

merged 1 commit into from
Nov 5, 2024

Conversation

will
Copy link
Owner

@will will commented Oct 31, 2024

partially address #291

@jwoertink does this make it not crash at least? I don't have a windows install to test on myself

@jwoertink
Copy link
Contributor

I think this might work... I'm now getting a different compiler error though...

I assume this isn't PG related.

Showing last frame. Use --error-trace for full trace.

In D:\a\_temp\crystal-latest-true-undefined\src\openssl\ssl\socket.cr:150:33

 150 | raise OpenSSL::SSL::Error.new(@ssl, bytes, "SSL_write")
                                 ^--
Error: Error: instance variable '@underlying_eof' of OpenSSL::SSL::Error must be Bool, not Nil
Error: Process completed with exit code 1.

src/pq/conninfo.cr Outdated Show resolved Hide resolved
@will
Copy link
Owner Author

will commented Oct 31, 2024

underlying_eof I don't think appears at all in this codebase. It could be something here is triggering that to be nil, I suppose, but I can't think of what that'd be

@jwoertink
Copy link
Contributor

I've been able to confirm that the error I got is not related to PG. I've found a fix and confirmed this patch does fix the original issue letting Avram compile on Windows.

@will will merged commit cafef48 into master Nov 5, 2024
1 check passed
@will will deleted the windowsusername branch November 5, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants