Improve the JS so it supports NodeJS #179
Conversation
…etermine the module system. Add uglifyjs and build script to package json
|
I forgot to mention that everything should work as before, the code was just rearranged. |
|
@bensampaio it would be good for you to explain the problem you are having at your work as an example in the documentation. The PR seems OK. I'm going to merge it. |
| _domains = []; | ||
| this.locale = get_current_locale(); | ||
| if (typeof document !== 'undefined') { | ||
| return document.documentElement.lang.replace('-', '_'); | ||
| } |
There was a problem hiding this comment.
you should return en as default locale (or use a different detection strategy). Putting it as null is a bad idea.
| /*! | ||
| * William DURAND <william.durand1@gmail.com> | ||
| * MIT Licensed | ||
| */ |
There was a problem hiding this comment.
please update the build script so that it keeps the license header
|
@stof, sorry for the delay on an answer. Since this was already merged, how do you propose I make the changes? I no longer have the forked repo. |
|
@bensampaio create a new PR |
|
This breaks when using RequireJs. |
I came across this problem when trying to implement server rendering on a ReactJS application dependent on the bazinga-translator. Since the variables
windowanddocumentdon't exist in NodeJS, the Translator initialization would always fail.To fix that, I improved the module system detection so that when required on NodeJS the code no longer fails because
documentandwindowdon't exist. Also removed the dependency on the variableundefined.Besides that, I added
uglify-jsas a dependency and the build script so other contributors don't need to guess which uglification options should be used. To uglify the JS now you just need to runnpm run buildunder theResourcesdirectory.What do you think?