Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern default option in DumpCommand + Update documentation #203

Merged

Conversation

monteiro
Copy link
Collaborator

@monteiro monteiro commented May 1, 2017

  • Updated documentation related with the new pattern argument
  • I've added a default value to the pattern option in DumperCommand. This way it keeps being backward compatible. Thanks to @kcivey.

@willdurand willdurand self-requested a review May 1, 2017 13:52
@kcivey
Copy link

kcivey commented May 1, 2017

Can't it just have a default value, so it's backward-compatible (#204)?

@monteiro monteiro changed the title Add pattern as required argument in dump command Add pattern default option in DumpCommand + Update documentation May 2, 2017
@monteiro monteiro merged commit d148c72 into willdurand:master May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants