-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github actions support (include PHP 8 tests) #309
Merged
Merged
Changes from 27 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2dd26f0
Create run-tests.yml
monteiro 4d06135
support different versions of symfony
monteiro 60a6bb0
wip+
monteiro 4a71f62
fix
monteiro f5cba4e
fix
monteiro 3495ce0
wip
monteiro e108a58
fix
monteiro f558b4c
remove cache
monteiro e71506d
wip
monteiro fdb6bc3
fx
monteiro 8eee740
add allowed to fail
monteiro a59f023
wip
monteiro 8b4fb5c
r
monteiro 54baaff
fix
monteiro 31631c8
disable libxml from tests on php version 8
monteiro c798fd3
fix
monteiro ad3f3a9
add phpunit 8 for php 8
monteiro 6974904
remove yet support for phpunit 8
monteiro 3f7e006
allow to fail
monteiro 38f578f
fix
monteiro ae0e474
allow to fail always true
monteiro 4227571
add xdebug for coverage
monteiro b5c12d4
always dependencies highest
monteiro 0cc94c4
add typehint
monteiro c760dca
fix
monteiro 339be63
add symfony version to title
monteiro 7dcdd9a
update
monteiro 2fdc3a4
Element phpunit, attribute syntaxCheck: The attribute syntaxCheck is …
monteiro c572028
remove xdebug
monteiro 582f161
add coverage
monteiro 3248986
fix
monteiro a6a119e
add xdebug
monteiro 71d8966
add env variable xdebug_mode
monteiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
name: "CI" | ||
|
||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- 'master' | ||
|
||
env: | ||
fail-fast: true | ||
PHPUNIT_FLAGS: "-v" | ||
SYMFONY_REQUIRE: ">=4.4" | ||
|
||
jobs: | ||
test: | ||
name: PHP ${{ matrix.php-version }} + Symfony ${{ matrix.symfony-version }} | ||
runs-on: 'ubuntu-latest' | ||
continue-on-error: ${{ matrix.allowed-to-fail }} | ||
|
||
strategy: | ||
matrix: | ||
php-version: ['7.2.5', '7.3', '7.4', '8.0'] | ||
variant: [normal] | ||
dependencies: [highest] | ||
allowed-to-fail: [true] | ||
symfony-version: [latest] | ||
include: | ||
- php-version: 7.2.5 | ||
dependencies: highest | ||
variant: normal | ||
allowed-to-fail: false | ||
symfony-version: latest | ||
- php-version: '8.0' | ||
dependencies: highest | ||
variant: normal | ||
allowed-to-fail: true | ||
symfony-version: latest | ||
- php-version: '7.4' | ||
dependencies: highest | ||
variant: 'symfony/symfony:"4.4.*"' | ||
allowed-to-fail: false | ||
symfony-version: 4.4 | ||
- php-version: '7.4' | ||
dependencies: highest | ||
variant: 'symfony/symfony:"5.1"' | ||
allowed-to-fail: false | ||
symfony-version: 5.1 | ||
steps: | ||
- name: "Checkout code" | ||
uses: actions/checkout@v2.3.3 | ||
|
||
- name: "Install PHP with extensions" | ||
uses: shivammathur/setup-php@2.7.0 | ||
with: | ||
coverage: "none" | ||
php-version: ${{ matrix.php-version }} | ||
tools: composer:v2 | ||
extensions: intl, xdebug | ||
|
||
- name: "Set composer cache directory" | ||
id: composer-cache | ||
run: echo "::set-output name=dir::$(composer config cache-files-dir)" | ||
|
||
- name: Install variant | ||
if: matrix.variant != 'normal' | ||
run: composer require ${{ matrix.variant }} --no-update | ||
|
||
- name: "Install Composer dependencies (${{ matrix.dependencies }})" | ||
uses: "ramsey/composer-install@v1" | ||
with: | ||
dependency-versions: "${{ matrix.dependencies }}" | ||
composer-options: "--prefer-dist" | ||
|
||
- name: "Install PHPUnit" | ||
run: vendor/bin/simple-phpunit install | ||
|
||
- name: "PHPUnit version" | ||
run: vendor/bin/simple-phpunit --version | ||
|
||
- name: "Run unit tests" | ||
run: vendor/bin/phpunit --coverage-text --verbose | ||
|
||
- name: "Run phantomjs tests" | ||
run: phantomjs Resources/js/run-qunit.js file://`pwd`/Resources/js/index.html | ||
|
||
- name: "Run phantomjs tests ES5" | ||
run: phantomjs Resources/js/run-qunit.js file://`pwd`/Resources/js/index-with-es5-shim.html |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
} | ||
], | ||
"require": { | ||
"php": "^7.1", | ||
"php": ">=7.2.5", | ||
"symfony/framework-bundle": "~4.4|~5.0", | ||
"symfony/finder": "~4.4|~5.0", | ||
"symfony/console": "~4.4|~5.0", | ||
|
@@ -26,7 +26,7 @@ | |
"symfony/browser-kit": "~4.4|~5.0", | ||
"symfony/twig-bundle": "~4.4|~5.0", | ||
"symfony/phpunit-bridge": "^5.0", | ||
"phpunit/phpunit": "^4.8|~5.7|~6.5" | ||
"phpunit/phpunit": "^4.8|~5.7|~6.5|~8" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. support PHP 8 |
||
}, | ||
"replace": { | ||
"willdurand/expose-translation-bundle": "2.5.*" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting what symfony composer.json has.