Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Symfony 6 #323

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Allow Symfony 6 #323

merged 4 commits into from
Dec 2, 2021

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Jul 18, 2021 •
edited
Loading

That's weird, I don't understand why the new matrix entry fails when running PHPUnit tests, it's working fine locally:
image

@monteiro monteiro self-requested a review August 4, 2021 14:40
@Kocal
Copy link
Contributor Author

Kocal commented Dec 1, 2021

@monteiro the PR has been rebased and the CI is green ✨

@monteiro monteiro merged commit 811fff5 into willdurand:master Dec 2, 2021
@monteiro
Copy link
Collaborator

monteiro commented Dec 2, 2021

Thanks a lot @Kocal !

@Kocal Kocal deleted the symfony-6 branch December 2, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monteiro monteiro Awaiting requested review from monteiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kocal @monteiro