Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #347
Due to the requirement to add the native return type in the Configuration class and the DumpCommand class which were neither final nor internal, this should be released as a new major version to respect semver.
All the
void
return type I'm adding as native return types are actually optional in Symfony 7. They will become required only in Symfony 8. As adding them also requires a major version, I'm adding them at the same time (so that Symfony 8 does not require a new bump of the major version).I also took the opportunity to mark classes as
@final
or@internal
to reduce the BC API of the bundle for the future. Note that for now, the command and controller are only marked as@final
but I'm wondering whether they could be marked as@internal
instead if they are only meant to be initialized by the service definition of this bundle.