Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Symfony 7 #348

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add support for Symfony 7 #348

merged 1 commit into from
Dec 18, 2023

Conversation

stof
Copy link
Contributor

@stof stof commented Dec 14, 2023

Closes #347

Due to the requirement to add the native return type in the Configuration class and the DumpCommand class which were neither final nor internal, this should be released as a new major version to respect semver.
All the void return type I'm adding as native return types are actually optional in Symfony 7. They will become required only in Symfony 8. As adding them also requires a major version, I'm adding them at the same time (so that Symfony 8 does not require a new bump of the major version).

I also took the opportunity to mark classes as @final or @internal to reduce the BC API of the bundle for the future. Note that for now, the command and controller are only marked as @final but I'm wondering whether they could be marked as @internal instead if they are only meant to be initialized by the service definition of this bundle.

@monteiro monteiro merged commit df5db0f into willdurand:master Dec 18, 2023
7 checks passed
@stof stof deleted the symfony_7 branch December 18, 2023 11:26
@stof
Copy link
Contributor Author

stof commented Dec 18, 2023

@monteiro when do you expect to make the release ?

@monteiro
Copy link
Collaborator

Today or tomorrow max.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Symfony 7
2 participants