Add the authenticated users URI as a Grantee URI to check #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, thanks for contributing. That's a good catch, to check for misc public users! |
willh
reviewed
May 2, 2018
index.js
Outdated
| @@ -22,7 +22,7 @@ exports.handler = (event, context) => { | |||
| // Grant[0] is always owner, so we only need to check further if we have more than 1 grant | |||
| if (grants.length > 1) { | |||
| for (const grant of grants) { | |||
| if (grant.Grantee.URI && (grant.Grantee.URI == allUsersUri || grant.Grantee.URI == authenticatedUsersUri) { | |||
| if (grant.Grantee.URI && (grant.Grantee.URI == allUsersUri || grant.Grantee.URI == authenticatedUsersUri)) { | |||
There was a problem hiding this comment.
Let's just squash those two commits together and nobody will ever know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Authenticated Users group" predefined group is also a group that can be in an ACL that grants effective public access to an S3 bucket:
This PR adds the group and checks for it.
Public access at the bucket level could also be done via bucket policy, but that's a bit tricker than just knowing a couple predefined groups to check for on an ACL and is outside the scope of this PR.