Bug crappy scp Fixes #13 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, this was a lot of work, but totally worth it!!!!
With this update, users can SCP/SFTP files from their local machine into the container on the other side of an SSH connection.
This new functionality totally deprecates the (crappy) functionality of SSH implemented via PR #7
To add this functionality, ContainerShell had to absorb the source of dockerpty so it could handle a non-TTY environment. Basically, dockerpty would always assume it operated with a TTY from the host, which works for standard SSHing. However, when using SCP/SFTP, you get no TTY, and in fact, a TTY breaks those protocols. When those protocols are all done sending data, they send a zero-byte packet to trigger an End Of File (EOF) on the remote end. Because of how dockerpty handled blocked when hijacking the local TTY, it wouldn't stop looping if stdin received an EOF.
Specifics about what I changed can be found via a PR I created with dockerpty:
d11wtq/dockerpty#82