Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement filesystem related functions using boost filesystem #2

Closed
willyd opened this issue Aug 18, 2015 · 9 comments
Closed

Implement filesystem related functions using boost filesystem #2

willyd opened this issue Aug 18, 2015 · 9 comments
Labels
ready for merge windows support

Comments

@willyd
Copy link
Owner

willyd commented Aug 18, 2015

Use boost filesystem instead of Unix specific implementations of:

MakeTempFile
MakeTmpDir
mkdir
@bhack
Copy link

bhack commented Aug 18, 2015

This will potentially conflict with BVLC#2537

@willyd
Copy link
Owner Author

willyd commented Aug 18, 2015

Should we rely on C++14 <filesystem> then?

@bhack
Copy link

bhack commented Aug 18, 2015

Yes but you need to investigate what are the minimal g++ clang and msvc version that support that and if this minimal versions are acceptable by core Caffe developers.

willyd pushed a commit that referenced this issue Sep 23, 2015
@ShaoqingRen
Merge pull request #2 from rbgirshick/faster-R-CNN-linux-compat
40213bf 
linux compat fixes
@eelstork
Copy link

I'm working on this.

@willyd
Copy link
Owner Author

willyd commented Nov 10, 2015

@eelstork Great looking forward to try it!

@eelstork
Copy link

@willyd does BVLC#3300 answer this?

@willyd
Copy link
Owner Author

willyd commented Nov 12, 2015

Yes I will close the issue when I merge these changes.

@willyd willyd mentioned this issue Nov 12, 2015
Closed
@eelstork
Copy link

@willyd I filed BVLC#3324 which looks related to this. Advising caution.

@willyd
Copy link
Owner Author

willyd commented Dec 11, 2015

Closing fixed by: BVLC#3300 and BVLC#3446

@willyd willyd closed this as completed Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready for merge windows support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@willyd @bhack @eelstork