Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented out spring-asciidoctor-backends in pom.xml? #112

Closed
Riggs333 opened this issue Apr 18, 2024 · 1 comment
Closed

Remove commented out spring-asciidoctor-backends in pom.xml? #112

Riggs333 opened this issue Apr 18, 2024 · 1 comment

Comments

@Riggs333
Copy link
Contributor

I noticed this commented out snippet in the pom.xml about spring-asciidoctor-backends:

htmx-spring-boot/pom.xml

Lines 151 to 160 in 46c13f1

<!-- Should be removed once spring-asciidoctor-backends is in Maven Central -->
<!--
<pluginRepositories>
<pluginRepository>
<id>spring-milestone</id>
<name>Spring Milestone Repository</name>
<url>https://repo.spring.io/milestone</url>
</pluginRepository>
</pluginRepositories>
-->

(I don't know yet what was planned to do with it (as I haven't found any asciidoc-files in this repository), maybe you wanted to create some documentation in spring style?)

Nevertheless, it looks like the artifact was published in January 2023 and is available in Maven Central.

If I misunderstood something and you want to keep the code in the pom.xml then feel free to close this issue.

@wimdeblauwe
Copy link
Owner

It can be removed indeed. Feel free to open a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants