-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing annotations for response headers #118
Add missing annotations for response headers #118
Conversation
b03bf62
to
a981c71
Compare
@tschuehly @wimdeblauwe one thing I have changed now is that |
htmx-spring-boot/src/main/java/io/github/wimdeblauwe/htmx/spring/boot/mvc/HxLocation.java
Show resolved
Hide resolved
6ca6c3b
to
9e8f235
Compare
I have made a few improvements to the Javadoc of the annotations. |
@wimdeblauwe I added another commit which introduces dedicated annotations It also makes it possible to configure triggers for all three lifecycles (directly after response was processed, after settle and after swap) in the same response. |
a65f505
to
0f9ab75
Compare
@xhaggi What is the reasoning to deprecate |
The reason for this is that all the places where it is used are now code paths that should not be used in the future. Or do you think there is a reason to leave it as it is? |
Maybe we should deprecate the @checketts There was no prior discussion about this as far as I know. For me, both the current and the new proposal are fine. But this:
Seems like a nice advantage of the separate annotations, so I think it is a good improvement. |
4cfecd3
to
512d937
Compare
Sure and done. I also updated the README where I missed to add the annotations. |
…After-Swap and support multiple events
512d937
to
eb12958
Compare
I've added another commit with small adjustments to reduce dupe code and make setting an htmx response header type-safe in |
I'm fine with the deprecation. We had created it to clarify the usage, but I haven't used it myself so making it more flexible is fine by me. |
This will add the missing annotations for all available response headers.
Superseded #117.