@HxPushUrl(true) now retreives the path from the request #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified setHxPushUrl() method to include HttpServletRequest and conditionally set HX-Push-Url header based on request URI and query parameters. Updated test cases and test controller to reflect these changes and ensure correct functionality.
xhaggi
reviewed
Aug 29, 2024
...ng-boot/src/main/java/io/github/wimdeblauwe/htmx/spring/boot/mvc/HtmxHandlerInterceptor.java
Outdated
Show resolved
Hide resolved
wimdeblauwe
reviewed
Aug 29, 2024
htmx-spring-boot/src/test/java/io/github/wimdeblauwe/htmx/spring/boot/mvc/TestController.java
Show resolved
Hide resolved
Refactored the HtmxHandlerInterceptor to consistently handle Htmx headers by considering query strings and consolidating logic into helper methods. Also added test cases for HxPushUrl and HxReplaceUrl with both path and boolean values, ensuring robust validation of headers. Modified HxReplaceUrl annotation to have a default value of TRUE.
|
@xhaggi @wimdeblauwe |
wimdeblauwe
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
@HxPushUrlwithout a value it pushestruein the url, instead of the fetched URLNow the path gets retreived from the request.