Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to mark HtmxResponse.Builder#reswap as deprecated because it was not part of a release #85

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

xhaggi
Copy link
Contributor

@xhaggi xhaggi commented Oct 13, 2023

Since the builder of HtmxResponse is not yet part of a release, I could have safely removed this method and not marked it as deprecated.

@xhaggi xhaggi changed the title No need to mark HtmxResponse.Builder#reswap as deprecated, because it was not part of a release No need to mark HtmxResponse.Builder#reswap as deprecated because it was not part of a release Oct 13, 2023
@wimdeblauwe
Copy link
Owner

Can you fix the merge conflicts? I wil merge after that.

@wimdeblauwe wimdeblauwe added this to the 3.1.0 milestone Oct 16, 2023
@xhaggi
Copy link
Contributor Author

xhaggi commented Oct 16, 2023

Done.

@wimdeblauwe wimdeblauwe merged commit 9c78b0c into wimdeblauwe:main Oct 16, 2023
1 check passed
@xhaggi xhaggi deleted the polishing/hx-reswap branch October 17, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants