fix CommandTOpen (GotoOrOpen) command #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2017
|
Thanks @tap349. This looks safe enough to try landing on the master branch... if it ends up breaking things for people, I'm sure we'll hear about it... |
ZyX-I
pushed a commit
to powerline/deps
that referenced
this pull request
Nov 21, 2017
vim-plugins/command-t tip:
commit 7147ba92c9c1eef8269fd47d47ba636ce7f365a6
Author: Greg Hurrell <greg@hurrell.net>
Date: Thu Nov 16 19:46:11 2017 -0800
Merge branch 'pull/315'
Closes: wincent/command-t#315
* pull/315:
doc: update AUTHORS and HISTORY
Fix GotoOrOpen command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR should fix #311 and maybe #314.
PR fixes
GotoOrOpencommand: nowGotoOrOpencommand usessbufferonly if buffer is visible in current or some other tab (newBufVisiblefunction checks that buffer exists, that it's loaded, listed and not hidden).Steps to reproduce the bug:
set hiddenin .vimrclet g:CommandTAcceptSelectionTabCommand = 'CommandTOpen tabe'<C-t>from Command-T:bd<C-t>again=> file is opened in horizontal split instead of a new tab.
Also I checked behaviour with
set nohidden- everything seems to work correctly.