feat: use watchman's watch-project if available
#390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If watchman is bersion 3.3 or later, use `watch-project` rather than the deprecated `watch`. The main advantage is eliminating redundant nested watches (i.e. where one is a subtree of another), which reduces RAM and CPU usage in the `watchman` daemon and eliminates the indexing delay when invoking Command-T after moving down the directory hierarchy. Although `watch-project` was introduced in 3.1 it is awkward/inefficient to use without the `relative_root` query which was introduced in 3.3. 3.3 was released in June 2015, so most users should have a newer version but backward compatibility with older versions is maintained. Fixes wincent#389 Tested: * Tested the new code under various scenarios by invoking Command-T in my homedir and various subdirectories, as well as other paths (/tmp). * Manually tested the fallback path to `watch`, which is unchanged from existing code. * Tested various version numbers by manually simulating the output of `--version` * If the version number is missing or malformed, it will end up as version 0.0 * test cases: nil, "", "foo.bar", "-5.2", "1", "3.2", 3.3.449", "4", "2022.06.13.00"
|
Thanks @mr-salty — this looks pretty good to me. I'm going to pull it down and run with it locally for a while to validate it before merging. |
|
Just documenting this for posterity — it seems that the project switched to date-based version numbers in the move from v4.9.0 to v2020.05.11.0, so the |
|
Fun fact: there is a |
|
Thanks for this @mr-salty. Seems to work well enough, and I think the risk is pretty low because most people aren't actually using the Watchman scanner, so I merged this. |
Padmamanickam
added a commit
to Padmamanickam/command-t
that referenced
this pull request
Feb 6, 2023
Closes: wincent/command-t#390 * pull/390: docs: update AUTHORS and HISTORY section refactor: make .watchmanconfig a valid JSON file style: apply comment edits and remove an unnecessary semi-colon perf: use watchman's `watch-project` if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If watchman is bersion 3.3 or later, use
watch-projectrather thanthe deprecated
watch. The main advantage is eliminating redundantnested watches (i.e. where one is a subtree of another), which reduces
RAM and CPU usage in the
watchmandaemon and eliminates the indexingdelay when invoking Command-T after moving down the directory hierarchy.
Although
watch-projectwas introduced in 3.1 it is awkward/inefficientto use without the
relative_rootquery which was introduced in 3.3.3.3 was released in June 2015, so most users should have a newer version
but backward compatibility with older versions is maintained.
Fixes #389
Tested:
and various subdirectories, as well as other paths (/tmp).
watch, which is unchanged from existing code.--version