add: menu in reader

windingwind · Oct 29, 2023 · e74b2bf · e74b2bf
1 parent d4fb0fc
commit e74b2bf
Show file tree

Hide file tree

Showing 5 changed files with 109 additions and 27 deletions.
diff --git a/addon/chrome/content/icons/favicon@0.5x.png b/addon/chrome/content/icons/favicon@0.5x.png
diff --git a/src/hooks.ts b/src/hooks.ts
@@ -32,7 +32,7 @@ async function onStartup() {
 
   await addon.api.actionManager.dispatchActionByEvent(
     ActionEventTypes.programStartup,
-    {},
+    {}
   );
 
   initReaderShortcuts();
@@ -42,12 +42,12 @@ async function onStartup() {
 
 async function onMainWindowLoad(win: Window): Promise<void> {
   initWindowShortcuts(win);
-  initMenu();
+  initMenu(win);
   await addon.api.actionManager.dispatchActionByEvent(
     ActionEventTypes.mainWindowLoad,
     {
       window: win,
-    },
+    }
   );
 }
 
@@ -57,7 +57,7 @@ async function onMainWindowUnload(win: Window): Promise<void> {
     ActionEventTypes.mainWindowUnload,
     {
       window: win,
-    },
+    }
   );
 }
 
@@ -88,7 +88,7 @@ async function onPrefsEvent(type: string, data: { [key: string]: any }) {
 async function onMenuEvent(type: "showing", data: { [key: string]: any }) {
   switch (type) {
     case "showing":
-      buildItemMenu(data.window);
+      buildItemMenu(data.window, data.target);
       break;
     default:
       return;

diff --git a/src/modules/menu.ts b/src/modules/menu.ts
@@ -3,16 +3,17 @@ import { config } from "../../package.json";
 import { getString } from "../utils/locale";
 import { getPref } from "../utils/prefs";
 import { ActionData } from "../utils/actions";
+import { getCurrentItems } from "../utils/items";
 
 export { initMenu, buildItemMenu };
 
-function initMenu() {
+function initMenu(win: Window) {
   ztoolkit.Menu.register("item", {
     tag: "menu",
-    popupId: `${config.addonRef}-itemPopup`,
+    popupId: `${config.addonRef}-item-popup`,
     label: getString("menupopup-label"),
     icon: `chrome://${config.addonRef}/content/icons/favicon.png`,
-    onpopupshowing: `Zotero.${config.addonInstance}.hooks.onMenuEvent("showing", { window })`,
+    onpopupshowing: `Zotero.${config.addonInstance}.hooks.onMenuEvent("showing", { window, target: "item" })`,
     children: [
       {
         tag: "menuitem",
@@ -21,12 +22,86 @@ function initMenu() {
       },
     ],
   });
+
+  ztoolkit.UI.appendElement(
+    {
+      tag: "menupopup",
+      id: `${config.addonRef}-reader-popup`,
+      listeners: [
+        {
+          type: "popupshowing",
+          listener: (ev) => {
+            addon.hooks.onMenuEvent("showing", { window, target: "reader" });
+          },
+        },
+      ],
+    },
+    win.document.querySelector("popupset")!
+  );
+  const image =
+    "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAACXBIWXMAAAsSAAALEgHS3X78AAAA40lEQVRYCWP8//8/AyFwJL/hjsbXJ8oEFSKBG9wyd20mNqgQUsdESMGCypkppFoOAiA924s711PsAOmfb2NItRwGWP7/FaTYAbQGow4YdcCoA0YdMOqAUQcMuANYCCm4yS394AWboD05hn9k5XrgSqkDjgloPiDHcih4kENAwWgaGHXAqAModcBFKB4QB4AsdoBish1BrgPAli8rNvsAwpQ4ghwHLIRZDhNAcsRCUg0jWBSjW76s2CwBmwTUEQlRvadA3HhiDSQlBHBajuYQkBqiQ4JYBxQSYzmaIwoJKmRgYAAAgCNBYXH3oBUAAAAASUVORK5CYII=";
+  const readerButtonCSS = `
+.actions-tags-reader-menu::before {
+  background-image: url(${image});
+  background-size: 100%;
+  content: "";
+  display: inline-block;
+  height: 16px;
+  vertical-align: top;
+  width: 16px;
+}`;
+  Zotero.Reader.registerEventListener("renderToolbar", (event) => {
+    const { append, doc } = event;
+    append(
+      ztoolkit.UI.createElement(doc, "button", {
+        namespace: "html",
+        classList: ["toolbarButton", "actions-tags-reader-menu"],
+        properties: {
+          tabIndex: -1,
+          title: "Actions",
+        },
+        listeners: [
+          {
+            type: "click",
+            listener: (ev: Event) => {
+              const _ev = ev as MouseEvent;
+              const target = ev.target as HTMLElement;
+              const elemRect = target.getBoundingClientRect();
+
+              const x = _ev.screenX - _ev.offsetX;
+              const y =
+                _ev.screenY - _ev.offsetY + elemRect.bottom - elemRect.top;
+
+              win.document
+                .querySelector(`#${config.addonRef}-reader-popup`)
+                // @ts-ignore XUL.MenuPopup
+                ?.openPopupAtScreen(x + 1, y + 1, true);
+            },
+          },
+        ],
+        children: [
+          {
+            tag: "span",
+            classList: ["button-background"],
+          },
+        ],
+      })
+    );
+    append(
+      ztoolkit.UI.createElement(doc, "style", {
+        id: `${config.addonRef}-reader-button`,
+        properties: {
+          textContent: readerButtonCSS,
+        },
+      })
+    );
+  });
 }
 
-function buildItemMenu(win: Window) {
+function buildItemMenu(win: Window, target: "item" | "reader") {
   const doc = win.document;
   const popup = doc.querySelector(
-    `#${config.addonRef}-itemPopup`
+    `#${config.addonRef}-${target}-popup`
   ) as XUL.MenuPopup;
   // Remove all children in popup
   while (popup.firstChild) {
@@ -93,7 +168,7 @@ function getActionsByMenu() {
 }
 
 async function triggerMenuCommand(key: string) {
-  const items = Zotero.getActiveZoteroPane().getSelectedItems();
+  const items = getCurrentItems();
   // Trigger action for all items
   await addon.api.actionManager.dispatchActionByKey(key, {
     itemIDs: items.map((item) => item.id),

diff --git a/src/modules/shortcuts.ts b/src/modules/shortcuts.ts
@@ -1,3 +1,4 @@
+import { getCurrentItems } from "../utils/items";
 import { KeyModifier } from "../utils/shorcut";
 import { waitUntil } from "../utils/wait";
 
@@ -19,8 +20,8 @@ function initReaderShortcuts() {
       () => (reader._internalReader?._primaryView as any)?._iframeWindow,
       () =>
         _initShortcuts(
-          (reader._internalReader._primaryView as any)?._iframeWindow,
-        ),
+          (reader._internalReader._primaryView as any)?._iframeWindow
+        )
     );
   });
 }
@@ -62,20 +63,7 @@ async function triggerShortcut(e: KeyboardEvent) {
   const shortcut = new KeyModifier(addon.data.shortcut.getRaw());
   addon.data.shortcut = undefined;
 
-  let items = [] as Zotero.Item[];
-  switch (Zotero_Tabs.selectedType) {
-    case "library": {
-      items = Zotero.getActiveZoteroPane().getSelectedItems();
-      break;
-    }
-    case "reader": {
-      const reader = Zotero.Reader.getByTabID(Zotero_Tabs.selectedID);
-      if (reader) {
-        items = [reader._item];
-      }
-      break;
-    }
-  }
+  const items = getCurrentItems();
   // Trigger action for multiple items
   await addon.api.actionManager.dispatchActionByShortcut(shortcut, {
     itemIDs: items.map((item) => item?.id),

diff --git a/src/utils/items.ts b/src/utils/items.ts
@@ -0,0 +1,19 @@
+export { getCurrentItems };
+
+function getCurrentItems() {
+  let items = [] as Zotero.Item[];
+  switch (Zotero_Tabs.selectedType) {
+    case "library": {
+      items = Zotero.getActiveZoteroPane().getSelectedItems();
+      break;
+    }
+    case "reader": {
+      const reader = Zotero.Reader.getByTabID(Zotero_Tabs.selectedID);
+      if (reader) {
+        items = [reader._item];
+      }
+      break;
+    }
+  }
+  return items;
+}