refactor: use replaceAll() instead of eval()
#550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eval()` is slower than the alternatives, and it is also unsafe. Using template string instead to avoid `eval()` calls.
windingwind
approved these changes
Aug 21, 2023
|
或许可以使用一些格式化字符串的库？ |
|
没有被大量使用，感觉没这个必要性 |
|
依赖越多风险越大，尽量少外部依赖 |
|
🚀 This ticket has been resolved in v1.1.0-beta.50. See Release v1.1.0-beta.50 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval()is slower than the alternatives, and it is also unsafe. Using template string instead to avoideval()calls.reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval#never_use_eval!