Coverity: fix util wmsetbg resource leak

window-maker · Mar 3, 2023 · 7475bc5 · 7475bc5
1 parent 35f87b5
commit 7475bc5
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/util/wmsetbg.c b/util/wmsetbg.c
@@ -505,7 +505,15 @@ static BackgroundTexture *parseTexture(RContext * rc, char *text)
 			iheight = image->height;
 		}
 
-		GETSTRORGOTO(val, tmp, 2, error);
+		/* cannot use GETSTRORGOTO() here
+		 * as we have to free image in case of error */
+		val = WMGetFromPLArray(texarray, 2);
+		if (!WMIsPLString(val)) {
+			wwarning("could not parse texture %s", text);
+			RReleaseImage(image);
+			goto error;
+		}
+		tmp = WMGetFromPLString(val);
 
 		if (!XParseColor(dpy, DefaultColormap(dpy, scr), tmp, &color)) {
 			wwarning("could not parse color %s in texture %s", tmp, text);