Improve CI testing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
romangg
commented
Mar 9, 2024
romangg
commented
- Run tests also on release build.
- Enable Unity Build for test targets. This reduces the compile time by around 40%.
- Run Clang-Tidy with current config.
There were some fixes in the newest clang-format release.
It is enabled by default, but we disable it of course for release builds, but also for coverage builds to speed up the compilation in ci. As a replacement we add another matrix job with the gcc preset to ensure that all possible gcc compositor warnings as errors are also catched in the example code.
In general tests should be run in release build configuration. On CI we now run them in both configurations, release and debug, to get more information.
To allow unity builds.
This significantly reduces the compile time.
With the unity builds there doesn't seem to be an oom problem anymore. An option is still added to the ci job, so that the number of threads can easily be reduced in the future in case there are oom problems again.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 50.02% 50.80% +0.78%
==========================================
Files 938 938
Lines 87251 87395 +144
Branches 45466 45307 -159
==========================================
+ Hits 43645 44402 +757
+ Misses 38496 38087 -409
+ Partials 5110 4906 -204 ☔ View full report in Codecov by Sentry. |
Using the Wrapland::Client namespace in tests doesn't work with unlimited unity builds as there is a collision with other X11 types in the global namespace. This is a theoretical problem, but for correctness let's fix it by not using the namespace in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.