Pull KWin patches (2024-05-23 - 2024-09-14) #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plasma expects these functions to exist in the D-Bus specs. For now we implement them only as a stub.
Plasma::Dialog contains logic that we don't want for a kwin window and is considered deprecated. Dialog uses the width of the main item which results in an unavoidable binding loop. PlasmaWindow allows us to propagate implicit sizes upwards correctly. BUG: 420757
It's unused.
This improves the integration of the XcursorTheme class with the rest of the Qt ecosystem, for example it should be possible to load cursor themes from Qt resources.
The effect does not work very well for two main reasons: Some clients will make a new popup rather than move an existing one, so whether it does anything is highly unpredictable as a user. Popups can be of massively different sizes with different amounts of text. This means the text in the smaller popup gets resized which doesn't look like a natural in-between state of the two popups. This defeats the objective of looking smoother. On top of that, it's rather glitchy. This effect was purely visual, no functionality changes. BUG: 473411 BUG: 466638 BUG: 416048 BUG: 461501 BUG: 466637
This effects is off by default, which means to instruct someone how to use it for debugging purposes, you need to both tell them to enable it, and then also teach them how to assign a shortcut for it. Since it's off by default, there's no harm in setting a shortcut, which simplifies the enablement instructions. I've chosen Meta+Ctrl+Alt+P, which uses so many modifiers that it won't conflict with anything.
The target position is zero, so they just move into the top left corner, which looks weird. With this commit, they just fade away without moving
Give label text background color to make it easier to distinct from the background. BUG:483016
If two mouse areas are stacked on top of each other and a button press event is sent so one of them accepts it, QMouseEvent::isAccepted() will still return false. It's a QtQuick bug, see the associated upstream bug report https://bugreports.qt.io/browse/QTBUG-126733. On the other hand, given that the MenuButton implements its own input handling, we can port it away from DecorationButton to mitigate the issue. BUG: 488993
This should help avoiding the window heap delegaet labels drawing on top of each other in Overview effect. BUG:489595
This is problematic as then we do not catch changes to animation speed settings, it also doesn't make the code more readable when it's only used in one place. BUG: 490703
It's the same as contentsRect
…top layout Hiding the desktop bar based on the desktop layout produces unexpected results. BUG: 482023
The hotspot should be relative to the window item being dragged, the scale applies to both.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 50.45% 50.71% +0.25%
==========================================
Files 939 940 +1
Lines 87387 87387
Branches 44887 45172 +285
==========================================
+ Hits 44093 44315 +222
+ Misses 38599 38385 -214
+ Partials 4695 4687 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to listings in #27.
Closes #27