Skip to content

Commit

Permalink
Pull request #27: changed phone to mobile
Browse files Browse the repository at this point in the history
Merge in SST/android-sdk from fix/deviceType to master

Squashed commit of the following:

commit 85395a378429e9c0082b82309299bac1f15e696c
Author: harsh.raghav@wingify.com <harsh.raghav@vwo.com>
Date:   Tue Oct 8 17:55:57 2024 +0530

    changed phone to mobile
  • Loading branch information
HarshWingify authored and Swapnil Chaudhari committed Oct 9, 2024
1 parent 1bd1642 commit 950c498
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public class AppConstants {
public static final String USER_TYPE_NEW = "new";
public static final String USER_TYPE_RETURNING = "ret";

public static final String DEVICE_TYPE_PHONE = "Phone";
public static final String DEVICE_TYPE_MOBILE = "Mobile";
public static final String DEVICE_TYPE_TABLET = "Tablet";

//region Keys in Events
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ public boolean evaluate(VWO vwo, JSONArray data) {
try {
String type = data.getString(i);
return isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_TABLET) ||
!isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_PHONE);
!isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_MOBILE);
} catch (Exception exception) {
VWOLog.e(VWOLog.SEGMENTATION_LOGS, "Unable to parse device type", exception,
false, false);
Expand All @@ -570,7 +570,7 @@ public boolean evaluate(VWO vwo, JSONArray data) {
try {
String type = data.getString(i);
return !isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_TABLET) ||
isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_PHONE);
isTablet && type.equalsIgnoreCase(AppConstants.DEVICE_TYPE_MOBILE);
} catch (Exception exception) {
VWOLog.e(VWOLog.SEGMENTATION_LOGS, "Unable to parse device type", exception,
false, false);
Expand Down

0 comments on commit 950c498

Please sign in to comment.