-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use typescript with wing cli and worker thread for preflight #5247
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-5247.fly.dev 🚀 Last Updated (UTC) 2023-12-20 01:50 |
BenchmarksComparison to Baseline 🟩⬜⬜🟥⬜🟥⬜🟥⬜🟥🟥🟥🟥
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2023-12-20 01:58 |
import { wing } from "ts4wing";
wing((app) => {
// stuff goes here
}) Interesting... the API reminds me a little bit of React's createRoot / root.render(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
tools/hangar/__snapshots__/test_corpus/valid/api_cors_default.test.w_compile_tf-aws.md
Outdated
Show resolved
Hide resolved
1bb2ece
to
aa2d0ad
Compare
Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.53.3. |
General Vibe
compile
,run
, andtest
). This is basically only usable for preflightThe entrypoint TS experience is different than the existing issue/story:
This was due to our usage of a "root" construct for testing isolation. The wing cli needs to have control over the instantiation of resources, so
new App()
is not really feasible because we don't want users to actually attach stuff at the app-level. It may be possible to get it working withnew App()
but the hacks needed didn't seem worth it.An added benefit of this approach is that the user no longer needs to call
app.synth()
Anecdotally, I have built an awscdk-based internal framework at a previous job that looked like this for a similar reason (to duplicate stuff across Stages) and it worked pretty well.
Indirect Changes
@types/node
versionFixes #3678
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.