Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransformableInfo should support symbols as keys #240

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

dancrumb
Copy link
Contributor

Being able to use a Symbol as a key for TransformableInfo makes it easier to create cleaner transforms.

The current typing forbids this, so this change enables it.

Being able to use a Symbol as a key for TransformableInfo makes it easier to create cleaner transforms.

The current typing forbids this, so this change enables it.
@dscalzi
Copy link

dscalzi commented Feb 3, 2023

cc @wbt please merge this, it has been a problem for over two years. It's incredibly annoying to have to copy the same typings patch on every project that uses winston.

This project looks largely unmaintained, but this is a zero-effort solution to a frustrating issue.

@dscalzi
Copy link

dscalzi commented Feb 3, 2023

reference: #111 #114

@wbt
Copy link
Contributor

wbt commented Feb 7, 2023

cc @wbt please merge this, it has been a problem for over two years. It's incredibly annoying to have to copy the same typings patch on every project that uses winston.

FYI @dscalzi, that claim seems a bit less than truthful given that TS support for this is only about a year and a half old.

this is a zero-effort solution

Also not true, for me or according to the folks complaining at #244.

@dscalzi
Copy link

dscalzi commented Feb 8, 2023

The issue was first reported more than 2 years ago and never received a response. Moreover, this package has provided a .d.ts file for 5 years https://github.com/winstonjs/logform/commits/master/index.d.ts, not only a year and a half.

@dscalzi
Copy link

dscalzi commented Feb 8, 2023

See #15 ...

@wbt
Copy link
Contributor

wbt commented Feb 9, 2023

Support for using symbols as index types, which is what this specific PR is about, has only been released for a year and a half.
That is what's causing problems at #244 - it's too recent a feature in TS.

@wbt wbt mentioned this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants